Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prefix validation to postProcessRegistries #1369

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Move prefix validation to postProcessRegistries #1369

wants to merge 3 commits into from

Commits on Sep 20, 2021

  1. Allow config authors to always use Prefix 

    Previously an unset Location was only allowed for wildcarded Prefixes.
This commit will allow configs with emtpy location or empty prefix, so
long as the other is valid.

Remove wildcard prefix check for empty location in rewriteReference.

Fixes:
1. containers#1191 (comment)
2. containers#1191 (comment)

Co-authored-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
    @lsm5 @mtrmac
    lsm5 and mtrmac committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    48ddd0e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Move prefix validation to postProcessRegistries 

    Fixes: containers#1191 (comment)

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
    @lsm5
    lsm5 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    63bb4cb View commit details
    Browse the repository at this point in the history

  2. Remove check for empty location from parseLocation 

    Empty location is now allowed with a valid prefix, and we check for
these in postProcessRegistries already.

This check doesn't need to exist.

Fixes: containers#1191 (comment)

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
    @lsm5
    lsm5 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    29d476d View commit details
    Browse the repository at this point in the history