Recognize "manifest unknown" errors reported by Harbor #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
May 13, 2024
docker/docker_client.go
Outdated
| @@ -1097,6 +1097,11 @@ func isManifestUnknownError(err error) bool { | |||
| if errors.As(err, &e) && e.ErrorCode() == errcode.ErrorCodeUnknown && e.Message == "Not Found" { | |||
| return true | |||
| } | |||
| // Harbor v2.10.2 | |||
| if errors.As(err, &e) && e.ErrorCode() == errcode.ErrorCodeUnknown && strings.Contains(e.Message, "not found") { | |||
There was a problem hiding this comment.
How about replace the error check above with:
if errors.As(err, &e) && e.ErrorCode() == errcode.ErrorCodeUnknown && strings.Contains(strings.ToLower(e.Message), "not found") {
There was a problem hiding this comment.
Thanks, good idea. Updated.
mtrmac
force-pushed
the
harbor-404
branch
2 times, most recently
from
062aa69
to
60b732e
Compare
|
LGTM |
|
LGTM |
|
LGTM |
|
For the record, this was confirmed to work in #2203 (comment) . |
... per data in containers#2203 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... per data in #2203 .