Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make running in the background the default #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

germag
Copy link
Collaborator

@germag germag commented Apr 23, 2024

We are moving to integrate this tool in podman, so we need to follow the podman command line convention. So, let's make running in the background the default behavior requiring -i/--interactive to spawn an SSH session.

Related #1

We are moving to integrate this tool in podman, so we
need to follow the podman command line convention.
So, let's make running in the background the default
behavior requiring `-i/--interactive` to spawn an SSH
session.

Signed-off-by: German Maglione <gmaglione@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Apr 23, 2024

Podman runs containers in the background using --detach, -d

   --detach, -d
       Detached mode: run the container in the  background  and
       print the new container ID. The default is false.

--interactive is to connect stdin to the application. So if podman bootc allowed users to enter their user name and password when prompted after the OS bootc.

@cgwalters
Copy link
Contributor

Before we make substantial UX changes let's do a tagged release so that we have a stable reference point, and anyone who wants to pin can do so.

@germag
Copy link
Collaborator Author

germag commented Apr 26, 2024

Podman runs containers in the background using --detach, -d

   --detach, -d
       Detached mode: run the container in the  background  and
       print the new container ID. The default is false.

--interactive is to connect stdin to the application. So if podman bootc allowed users to enter their user name and password when prompted after the OS bootc.

Yes,

I'm not sure if we can map 1:1 podman behavior. We can add --detach, -d as default (plus printing the VM id), but I think we only have two modes, interactive (spawning an ssh session) or background (without spawning an ssh session)

@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

SGTM. Bottom line look at how Podman does something and then match the Podman CLI options if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants