Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DropDownMenuItem UI component #6918

Closed
Tracked by #5757
jeffmaury opened this issue Apr 24, 2024 · 1 comment · Fixed by #7233
Closed
Tracked by #5757

Implement DropDownMenuItem UI component #6918

jeffmaury opened this issue Apr 24, 2024 · 1 comment · Fixed by #7233
Assignees
@axel7083
Labels
area/ui-components

Comments

@jeffmaury
Copy link
Contributor

No description provided.

@jeffmaury jeffmaury mentioned this issue Apr 24, 2024
Open
22 tasks
@jeffmaury jeffmaury mentioned this issue Apr 24, 2024
Open
@axel7083
Copy link
Contributor

IMO the hidden property should not exists on this component.

podman-desktop/packages/renderer/src/lib/ui/DropDownMenuItem.svelte

Line 9 in 8419cb6

export let hidden = false;

In this scenario, parent wanting to hide should use class:hidden={true} and the component should propagate the class to the first div using $$props.class

@jeffmaury jeffmaury assigned axel7083 and unassigned cdrage May 15, 2024
@axel7083 axel7083 mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axel7083 axel7083

Labels
area/ui-components
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(UI): migrate DropdownMenu component axel7083/podman-desktop
3 participants
@jeffmaury @cdrage @axel7083