Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): migrate DropdownMenu component #7233

Merged
merged 4 commits into from
May 28, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented May 16, 2024

What does this PR do?

Migrating DropdownMenu component to ui library

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #6918

How to test this PR?

  • Pipeline should be ✅

@axel7083 axel7083 requested review from benoitf and a team as code owners May 16, 2024 11:59
@axel7083 axel7083 requested review from feloy, lstocchi and deboer-tim and removed request for a team May 16, 2024 11:59
@axel7083 axel7083 marked this pull request as draft May 16, 2024 12:01
@axel7083 axel7083 force-pushed the feature/migrate-dropdown-component branch from 25aa77e to b521828 Compare May 16, 2024 12:02
@axel7083 axel7083 marked this pull request as ready for review May 16, 2024 12:17
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should expose this as Dropdown unless we know it can be used as a replacement for a select control (e.g. in Settings > Preferences), which I don't think it does. Let's find another name or talk about options for meeting both needs.

@axel7083
Copy link
Contributor Author

Converting to draft for now as more discussion required

@axel7083 axel7083 marked this pull request as draft May 16, 2024 13:19
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 force-pushed the feature/migrate-dropdown-component branch from 79b32d7 to cac7317 Compare May 27, 2024 13:02
@axel7083 axel7083 changed the title feat(UI): migrate dropdown component feat(UI): migrate DropdownMenu component May 27, 2024
@axel7083 axel7083 marked this pull request as ready for review May 27, 2024 13:03
@axel7083 axel7083 requested a review from deboer-tim May 27, 2024 14:20
@axel7083
Copy link
Contributor Author

Re-opened

@axel7083 axel7083 merged commit e27322a into containers:main May 28, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DropDownMenuItem UI component
5 participants