chore: expose appearance preference #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Light mode still needs a lot of work, but we hope to include it as an experimental feature in the next release. Exposing the preference now will give more time for others to try it out, and make flipping back and forth to test PRs easier. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
Moving out of draft, I think we're far enough along that we should get more people looking at light mode, and will be easier to test with a setting. |
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
axel7083
approved these changes
May 29, 2024
agreed and it will help, LGTM my side |
cdrage
approved these changes
May 29, 2024
cdrage
pushed a commit
to cdrage/podman-desktop
that referenced
this pull request
May 30, 2024
chore: expose experimental appearance preference Light mode still needs a lot of work, but we hope to include it as an experimental feature in the next release. Exposing the preference now will give more time for others to try it out, and make flipping back and forth to test PRs easier. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have four PRs in review for light mode, and hopefully only a few more until it still has issues but might be ready for experimental support/early feedback. It takes longer to test because the preference is hidden.
Creating this draft PR to make it easy to apply and test, and so that it's ready when the time comes.
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #7362.
How to test this PR?
Just confirm the setting is visible, and appearance changes when you change it.