Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing duplicates definition of KubernetesGeneratorSelector #7206

Conversation

axel7083
Copy link
Contributor

What does this PR do?

We are using a duplicate definition of KubernetesGeneratorSelector, when the one from the @podman-desktop/api is the same.

Screenshot / video of UI

What issues does this PR fix or reference?

Would be great and would simplify #6300

How to test this PR?

  • Pipeline should be ✅

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners May 14, 2024 12:16
@axel7083 axel7083 requested review from dgolovin and feloy and removed request for a team May 14, 2024 12:16
@benoitf
Copy link
Collaborator

benoitf commented May 14, 2024

I'm not sure we should use external API internally

@axel7083
Copy link
Contributor Author

I'm not sure we should use external API internally

We are already at many, many places:

import type { CliToolState, ProviderImages } from '@podman-desktop/api';

import type { ContainerProviderConnection } from '@podman-desktop/api';

import type { ContainerProviderConnection } from '@podman-desktop/api';

import type {
Link,
ProviderCleanupAction,
ProviderConnectionStatus,
ProviderDetectionCheck,
ProviderImages,
ProviderInformation,
ProviderLinks,
ProviderStatus,
} from '@podman-desktop/api';

@benoitf
Copy link
Collaborator

benoitf commented May 14, 2024

I'm not sure that because someone did that, that it's the way to go

@axel7083
Copy link
Contributor Author

Closing as will keep as it is

@axel7083 axel7083 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants