-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move LinearProgress to ui package #7232
Conversation
packages/ui/package.json
Outdated
@@ -67,6 +67,10 @@ | |||
"./Tab": { | |||
"types": "./dist/tab/Tab.svelte.d.ts", | |||
"svelte": "./dist/tab/Tab.svelte" | |||
}, | |||
"./LinearProgress": { | |||
"types": "./dist/spinner/LinearProgress.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you rename the spinner
directory to progress
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the change 🚀
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
What does this PR do?
it moves the LinearProgress to the ui package.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
it resolves #6901
How to test this PR?