Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency containers/automation_images to v20231004 #335

Merged
merged 1 commit into from Nov 13, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Update Change
containers/automation_images major 20230816t191118z-f38f37d13 -> 20231004t194547z-f39f38d13

Release Notes

containers/automation_images (containers/automation_images)

v20231004t194547z-f39f38d13

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from cevich October 17, 2023 19:41
@cevich
Copy link
Member

cevich commented Oct 18, 2023

@umohnani8 PTAL, there's likely going to be a gating-test failure about a circular-dependency. I don't know this code, but my past python experience tells me these can be very tricky to fix w/o code-base knowledge. Can you help or help track down someone who can fix this?

@jwhonce
Copy link
Member

jwhonce commented Oct 20, 2023

@cevich @umohnani8 This is going to take a deep drive into why pylint is throwing an error on podman/errors/exceptions.py:1:0: R0401: Cyclic import (podman.api -> podman.api.client) (cyclic-import) when that code was not changed.

podman/api/ssh.py Outdated Show resolved Hide resolved
podman/api/uds.py Outdated Show resolved Hide resolved
@cevich
Copy link
Member

cevich commented Oct 25, 2023

when that code was not changed.

I don't think I have any idea how to do that, but I agree it's strange. Could it be caused by changed package/module names in an updated (third-party) dependency maybe?

@cevich
Copy link
Member

cevich commented Oct 25, 2023

************* Module podman.errors.exceptions
podman/errors/exceptions.py:1:0: R0401: Cyclic import (podman.api -> podman.api.client) (cyclic-import)

@jwhonce is there a way to make the output more verbose, to provide more clues?

@umohnani8
Copy link
Member

So the cyclic import issue seems to be a bug with pylint based on pylint-dev/pylint#3285 and pylint-dev/pylint#3525. The issues say it has been fixed but our CI is still running into it even though I am not able to reproduce it locally with pylint podman.

I checked the pylint versions and locally I am on 2.14.2 while I believe the CI is on 3.0.2 - so not sure why it is running into that issue.

In #338 I have added a disable to that block to see if that works but I am not sure if it is the best way to go. @jwhonce wdyt?

@umohnani8
Copy link
Member

Nevermind, the disable doesn't help with the cyclic import issue :(

@cevich
Copy link
Member

cevich commented Nov 7, 2023

Thanks for looking into this @umohnani8. I think we just need new CI VM images then, and a bit of luck they contain the fixed version.

cevich added a commit that referenced this pull request Nov 7, 2023
Ref:
#335 (comment)

Thanks to @umohnani8 for tracking this down.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member

cevich commented Nov 7, 2023

Let's try these images built yesterday by Ed (thanks!)...

@cevich
Copy link
Member

cevich commented Nov 7, 2023

...Ugh, no updated package yet, still get same error:

podman/errors/exceptions.py:1:0: R0401: Cyclic import (podman.api -> podman.api.client) (cyclic-import)

But at least now we know what to do/look for. There's a podman issue (IIRC) needing new CI VM images, and these ones I just tried are also no good there. Point is, there should be new images flowing through in the near-term.

@umohnani8
Copy link
Member

@cevich I fixed the issue in #338. Once that is in, we should be good to rebase on top of that to get the tests passing here :)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from b487c86 to c009609 Compare November 13, 2023 15:00
@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2023

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, renovate[bot], rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a9049e8 into main Nov 13, 2023
15 checks passed
@renovate renovate bot deleted the renovate/major-ci-vm-image branch November 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants