urfave/cli: fix parsing of short opts

[vrothberg]

Vendor an updated version of urfave/cli to fix the parsing of short
options. Until the fix is merged upstream, vendor the code from
github.com/vrothberg/cli containing both, the latest urfave/cli and
the bug fix.

Fixes: #714
Signed-off-by: Valentin Rothberg vrothberg@suse.com

[vrothberg]

I'll add a test to test/e2e just to make sure we don't hit that again in the future.

[rhatdan]

LGTM

[rhatdan]

@edsantiago @mheon @baude PTAL

[giuseppe]

LGTM, is there an open PR upstream that we can link to?

[vrothberg]

LGTM, is there an open PR upstream that we can link to?

Yes, it's here: urfave/cli#758

[rhatdan]

@rh-atomic-bot r+

Of course @edsantiago will find a way to break this again. :^)

[rh-atomic-bot]

📌 Commit 0b9ee59 has been approved by rhatdan

[rh-atomic-bot]

⚡ Test exempted: pull fully rebased and already tested.

[vrothberg]

Of course @edsantiago will find a way to break this again. :^)

Challenge accepted 😆

[giuseppe]

I've tried:

podman run --uidmap 0:30000:7000 --gidmap 0:30000:7000  -ti --rm alpine echo hello

and it seems that podman now enters an endless loop, I've done a quick test reverting the patch and I don't see the issue anymore. Does it happen for you as well?

[vrothberg]

Does it happen for you as well?

Yes, you're good ;-)

[vrothberg]

I'll have a look at it to (hopefully) prepare a patch.

[vrothberg]

The bug is here: https://github.com/vrothberg/cli/blob/fix-short-opts-parsing/command.go#L207

Instead of adding the argument, the to-be-translated string is added.

[vrothberg]

@giuseppe Here's the fix: #1066

I think, the challenge is open again 😆