Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor containers/common@main #10844

Merged
merged 2 commits into from Jul 2, 2021
Merged

vendor containers/common@main #10844

merged 2 commits into from Jul 2, 2021

Conversation

vrothberg
Copy link
Member

Pull in fixes for local image lookups.

Fixes: #10835
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@vrothberg
vendor containers/common@main
7eb9ed9 
Pull in fixes for local image lookups.

Fixes: containers#10835
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

@Luap99
Copy link
Member

Luap99 commented Jul 2, 2021

Sorry @vrothberg, we have to revert the cobra bump in c/common, see #10841. The flag completion is completely broken, spf13/cobra#1437

@vrothberg
Copy link
Member Author

Sorry @vrothberg, we have to revert the cobra bump in c/common, see #10841. The flag completion is completely broken, spf13/cobra#1437

Thanks for the pointer. I will force cobra to github.com/spf13/cobra v1.1.3 here in Podman. I am sure that other dependencies want to bump it as well.

@vrothberg
force github.com/spf13/cobra@v1.1.3
735be12 
v1.2.0 is breaking CI (see containers/pull/10844).

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Luap99
Luap99 reviewed Jul 2, 2021
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2021

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
@vrothberg vrothberg mentioned this pull request Jul 2, 2021
Closed
@vrothberg
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0420987 into containers:main Jul 2, 2021
@vrothberg vrothberg deleted the vendor-common branch July 2, 2021 12:33
cdoern pushed a commit to cdoern/podman that referenced this pull request Jul 6, 2021
@vrothberg @cdoern
force github.com/spf13/cobra@v1.1.3
3347b6c 
v1.2.0 is breaking CI (see containers/pull/10844).

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
rugk pushed a commit to rugk/podman that referenced this pull request Jul 9, 2021
@vrothberg @rugk
force github.com/spf13/cobra@v1.1.3
e68d6a2 
v1.2.0 is breaking CI (see containers/pull/10844).

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'image not known' for 'podman save' with arm64 image
4 participants
@vrothberg @Luap99 @rhatdan @openshift-merge-robot