Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the custom cobra vendor #8534

Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 1, 2020

Vendor in the latest cobra release v1.1.1

This will hurt the completion experience but is required for
proper packaging, see: #8528.

The best solution is to keep the current scripts since they
work fine with cobra v1.1.1.

@vrothberg
Copy link
Member

I suggest to wait before merging. Reverting would be sad. Your work is fantastic and I am optimistic we can keep it.

I dropped a comment in spf13/cobra#1258 to pull in Eric who can help us speed things up upstream. Vendoring a non-release commit is already a huge improvement over vendoring a fork.

@vrothberg
Copy link
Member

I like this approach. We keep the great bash completions but use the upstream cobra!

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Dec 1, 2020

The best thing is to keep the current scripts, they work fine with cobra v1.1.1

One problem with that is that podman completion will not generate the best possible scripts. However this is fine since we store the best scripts in ./completions/ and these are used for packaging. I don't think many users want to use this command anyway.
And we would also add one small bug: spf13/cobra#1258

Vendor in the latest cobra release v1.1.1

This will hurt the completion experience but is required for
proper packaging, see: containers#8528.

The best solution is to keep the current scripts since they
work fine with cobra v1.1.1.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
@umohnani8
Copy link
Member

LGTM
@baude @rhatdan @mheon PTAL

@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2020

/lgtm
/approve
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4b5cb7b into containers:master Dec 1, 2020
@Luap99 Luap99 deleted the revert-Luap99-cobra-vendor branch January 2, 2021 20:18
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants