Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to log to stdout #1669

Closed
wants to merge 1 commit into from
Closed

Conversation

iNoahNothing
Copy link

This PR simply adds a flag that allows users to configure if logrus logs to stderr (the default) or stdout.

Logrus currently cannot log to different locations based on the log levels and defaults to logging all levels to stderr. This causes issues when systems are collecting these logs and reporting INFO logs as errors because they are logged to stderr. This provides a simple mechanism for changing that behavior.

Signed-off-by: Noah Krause krausenoah@gmail.com

Signed-off-by: Noah Krause <krausenoah@gmail.com>
@mtrmac
Copy link
Collaborator

mtrmac commented Jun 9, 2022

Thanks. Why is this extra flag necessary instead of just using shell’s redirection (2>&1, &>, |&)?

@TomSweeneyRedHat
Copy link
Member

Changes LGTM
But if we go forward with this, we'll also need a man page change, I think here:https://github.com/containers/skopeo/blob/main/docs/skopeo.1.md

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@mtrmac mtrmac closed this Jul 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants