Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/parsers: Enable GetKernelVersion on FreeBSD #1425

Merged
merged 1 commit into from Nov 9, 2022

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Nov 8, 2022

This is needed by podman/test/utils.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson dfr@rabson.org

@rhatdan
Copy link
Member

rhatdan commented Nov 8, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 8, 2022

@nalind
Copy link
Member

nalind commented Nov 8, 2022

Should probably tweak the error message in the version of uname() in pkg/parsers/kernel/uname_unsupported.go.

This is needed by podman/test/utils.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
@dfr
Copy link
Contributor Author

dfr commented Nov 9, 2022

Rebased and changed the error message

@nalind
Copy link
Member

nalind commented Nov 9, 2022

/approve

1 similar comment
@nalind
Copy link
Member

nalind commented Nov 9, 2022

/approve

@rhatdan rhatdan merged commit a1a74c4 into containers:main Nov 9, 2022
@dfr dfr deleted the freebsd-test branch November 10, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants