Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the priority for picking the storage driver configurable #1460

Merged
merged 2 commits into from
Jan 6, 2023

Commits on Jan 5, 2023

  1. Make the priority for picking the storage driver configurable

    This fixes containers#1457
    
    Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
    Signed-off-by: Dan Čermák <dcermak@suse.com>
    dcermak and vrothberg committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    881ac48 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Only warn about 'driver' not being set if the priority list is unset

    Currently we would display an error when the user does not specify a `driver` in
    their config file. This has been present for historical reasons mostly to
    prevent users from accidentally getting the vfs
    driver (containers#1460 (comment)). Now
    that most systems support the overlay driver natively, we can reduce this to a
    warning and only warn about it if the driver_priority list is unset. If it is
    provided, then clearly the user or the distribution wanted for c/storage to pick
    a driver itself and the warning would be only confusing to users.
    
    Signed-off-by: Dan Čermák <dcermak@suse.com>
    dcermak committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    b2b2fef View commit details
    Browse the repository at this point in the history