Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v1.49.0 #1693

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Bump to v1.49.0 #1693

merged 2 commits into from
Aug 22, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 22, 2023

No description provided.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan merged commit 3add991 into containers:main Aug 22, 2023
1 of 18 checks passed
@vrothberg
Copy link
Member

Can elaborate on why we need a new minor release?

@vrothberg
Copy link
Member

... and why you force merged it without review?

@vrothberg
Copy link
Member

#1691 should be part of it at least

@rhatdan
Copy link
Member Author

rhatdan commented Aug 22, 2023

There only integers we have plenty to go around. Previous update is causing Vendoring to go haywire. This update will fix that and prevent future updates of older versions from hitting other repos incorrectly.

@vrothberg
Copy link
Member

So we do releases now to work around vendor bots and all that without reviews? I am really no fan :(

@rhatdan
Copy link
Member Author

rhatdan commented Aug 22, 2023

We did not release for two months and builtup a lot of fixes, and bumping takes 10 seconds and affects very little to work around bots issues.

@vrothberg
Copy link
Member

We just did a patch release (1.48.1) today. 1.49.0 will not be used anywhere and is missing patches (#1691). I assume the sole purpose was to silence the vendor bots but I hope there's a better solution than cutting ghost releases.

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 29, 2023

I assume the sole purpose was to silence the vendor bots but I hope there's a better solution than cutting ghost releases.

Merge the release branch into the main one, as c/image is now regularly doing.

That would also surface the code missing on the main branch, and bring it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants