Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlay: with imagestore keep merged with graphroot #1705

Merged
merged 1 commit into from
Sep 11, 2023
Merged

overlay: with imagestore keep merged with graphroot #1705

merged 1 commit into from
Sep 11, 2023

Conversation

flouthoc
Copy link
Collaborator

When imagestore is used as configuration to simulate split-store fs , keep merged with original graphroot and only keep read-only lower dir in imagestore.

@flouthoc
overlay: with imagestore keep merged with graphroot
4fe91c0 
When `imagestore` is used as configuration to simulate `split-store` fs
, keep `merged` with original `graphroot` and only keep `read-only`
`lower` dir in `imagestore`.

Signed-off-by: Aditya R <arajan@redhat.com>
@flouthoc
Copy link
Collaborator Author

@giuseppe @haircommander @kannon92 PTAL

giuseppe
giuseppe approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

could we get a test?

@flouthoc
Copy link
Collaborator Author

I am expecting all tests in https://github.com/containers/storage/blob/main/tests/split-store.bats to pass, but sure let me try to add a dedicated test for this.

@haircommander
Copy link
Contributor

LGTM, thanks!

@kannon92
Copy link
Contributor

I am testing this in a draft PR for CRIO now.

@kannon92
Copy link
Contributor

kannon92 commented Sep 11, 2023 •
edited

Getting this error when I try to create a pod.

FATA[0000] run pod sandbox: rpc error: code = Unknown desc = creating pod sandbox with name "k8s_podsandbox1_redhat.test.crio_redhat-test-crio_1": creating read-write layer with ID "ef9dfdf5b868ed4060f6eb074db2b159b09bbad025fc045b3d7fa299adc05d85": Stat /var/lib/containers/storage/overlay/e3e5579ddd43c08e4b5c74dc12941a4ef656fab070b1087a1fd5a8a836b71e7d/diff: no such file or directory

There is no container id directory here.

I need to look into this on my end actually.

@TomSweeneyRedHat
Copy link
Member

LGTM
but I'd like a test and to hear back from @kannon92 about his testing before merging.

@kannon92
Copy link
Contributor

This is working!

My issue was due to not running CRIO/storage on a fresh directory. Once I renamed my /var/lib/containers/storage and had it recreate from scratch everything is working.

@rhatdan rhatdan merged commit 60cff19 into containers:main Sep 11, 2023
18 checks passed
@kannon92
Copy link
Contributor

Not to be a bother but is there a possibly to kick off a release for this soon?

I'm carrying a few changes in cri-o/cri-o#7269 related to support for this?

I'd love a patch or a new release to not have to carry these as vendored changes.

@flouthoc
Copy link
Collaborator Author

@kannon92 I think v1.50.0 should contain the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@flouthoc @haircommander @kannon92 @TomSweeneyRedHat @giuseppe @rhatdan