Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlay: do not precreate the composefs layers dir #1734

Merged
merged 1 commit into from
Oct 19, 2023
Merged

overlay: do not precreate the composefs layers dir #1734

merged 1 commit into from
Oct 19, 2023

Conversation

giuseppe
Copy link
Member

Let's not pre-create the composefs layers dir every time we mount a layer, but do it only when there is a composefs blob to use.

Closes: #1733

@giuseppe giuseppe mentioned this pull request Oct 18, 2023
Closed
nalind
nalind reviewed Oct 18, 2023
View reviewed changes
drivers/overlay/overlay.go Outdated Show resolved Hide resolved
@giuseppe
overlay: do not precreate the composefs layers dir
5b5689f 
Let's not pre-create the composefs layers dir every time we mount a
layer, but do it only when there is a composefs blob to use.

Closes: containers#1733

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the no-precreate-composefslayers-dir branch from 6f4bbe4 to 5b5689f Compare October 18, 2023 19:46
@nalind
Copy link
Member

nalind commented Oct 18, 2023

LGTM. Ideally we'd do a mount --bind --read-only of the read-only store directory onto itself after it's set up in the "additional-stores" test and unmount it at the end, but I don't see a way to guarantee that it's unmounted if the test fails for any other reason before it hits the end of the test function.
/lgtm
/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot merged commit 79aa304 into containers:main Oct 19, 2023
19 checks passed
@cgwalters cgwalters added the area/composefs composefs related changes label Dec 4, 2023
@DennisGlindhart DennisGlindhart mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalind nalind nalind approved these changes

Assignees

@nalind nalind

Labels
approved area/composefs composefs related changes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing to (read-only) additionalimagestores when building image
3 participants
@giuseppe @nalind @cgwalters