Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#404): implement basic webex functionality to shoutrrr #405

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

surdaft
Copy link

@surdaft surdaft commented Nov 2, 2023

Implements a basic version of webex, future plans to add cards as well, but for now this satisfies webex being available.

image

closes #404 (heh, 404)

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really well done. Good job!

My suggestion would be to pass the roomId as a query parameter instead to allow for sending to multiple rooms. It would require the hostname to be a static string (which is generally just ignored by other services that have this problem).

Also, even though it's very simple, add the macro for including auto-generated docs so that the docs align with the other services. It's the scissor-looking thing at the bottom of the other services markdown files.

@surdaft
Copy link
Author

surdaft commented Nov 3, 2023

Thanks very much! Query param for roomID, fair enough I will take a poke. Do you have an example other service?

Ooh I see, I wondered what that was for. Thanks for the clarification, I will add the scissors when I have a moment. :)

@piksel
Copy link
Member

piksel commented Nov 4, 2023

Sure, the telegram service is similar and loops over its targets (chats) when sending:

func (service *Service) Send(message string, params *types.Params) error {

It's configured using the key tag (the second arg channels is an alias for backwards compatibility):

Chats []string `key:"chats,channels" desc:"Chat IDs or Channel names (using @channel-name)"`

Even if you only support a single room for now, using a query variable allows for adding support for multiple ones in the future without breaking compatibility. It also aligns it better with the other services. Thanks for taking the time!

@surdaft
Copy link
Author

surdaft commented Nov 7, 2023

  • I have updated to provide a rooms query parameter, which is comma separated like telegram.
  • I also tweaked the docs page to better reference how the discord and telegram docs show the URL structure, it was slightly different. I don't remember where I copied it from. 😅
  • Snippers added

@surdaft
Copy link
Author

surdaft commented Nov 9, 2023

Just a whee nudge 😄

Also quick Q: How long would it be before we can expect watchtower and shepard to update with the new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Webex support
2 participants