Skip to content

Commit

Permalink
Do not flush the template output buffer (see #1728)
Browse files Browse the repository at this point in the history
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | isotope/core#2131, isotope/core#2140


As discussed on Slack, `fastcgi_finish_request` (and other output buffer methods) break our logic of simulating a kernel request/response behavior. As @ausi suggested, we're not removing the `Template::flushAllData()` method (because it is public), but we shouldn't flush the data anymore on `Template::output()`.

Commits
-------

81a5712 Do not flush the template output buffer
  • Loading branch information
aschempp committed May 11, 2020
1 parent 9ec74c0 commit 4cac680
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions core-bundle/src/Resources/contao/library/Contao/Template.php
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,6 @@ public function output()
header('Content-Type: ' . $this->strContentType . '; charset=' . \Config::get('characterSet'));

echo $this->strBuffer;

// Flush the output buffers (see #6962)
$this->flushAllData();
}

/**
Expand Down

0 comments on commit 4cac680

Please sign in to comment.