-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for hotwired/turbo in the backend #7011
Draft
m-vo
wants to merge
4
commits into
contao:5.x
Choose a base branch
from
m-vo:turbo
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
reviewed
Mar 12, 2024
ausi
reviewed
Mar 12, 2024
ausi
reviewed
Mar 12, 2024
m-vo
force-pushed
the
turbo
branch
4 times, most recently
from
March 12, 2024 16:16
a150347
to
a179f30
Compare
ausi
reviewed
Mar 12, 2024
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
fritzmg
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two issues that I noticed:
- When going from any page to the file manager, there will be a JS error regarding DropZone. This is because the DropZone JavaScript is only added there - which is ignored by Turbo by default (without
data-turbo-track="reload"
). - For some reason the navigations panes in the main nav are getting toggled randomly sometimes, when navigating with Turbo Drive.
We also need to change all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt to add Turbo in the backend. This does not yet enable frames or uses streams at any place but enables drive by default. We will likely need to disable it by default and then enable it again for specific scenarios but this is a good starting point to see what would actually break.
For now these are the things we are doing:
rt
query parameter, so that things like GET requests to delete resources won't be triggered.BackendController
if a widget was rendered with an error, so that forms still work.