Handle deleted model classes when purging tokens #7188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhj
changed the title
|
How can the class of an opt-in token be deleted? Did you remove an implementation that used opt-in tokens? |
|
Yes, I used the OptIn service for an own implemention. That implementation does not exist anymore, but the OptIn tokens (referencing to that old implementation, table names |
fritzmg
reviewed
May 23, 2024
| } catch (\RuntimeException $e) { | ||
| // Class does not exist anymore, token can be deleted | ||
| break; | ||
| } | ||
|
|
||
| /** @var Model $model */ | ||
| $model = $this->framework->getAdapter($class); |
There was a problem hiding this comment.
Doesn't the error happen here rather than with $class = $adapter->getClassFromTable($table);? The latter just returns a string and should always work, even if the class does not exist anymore.
There was a problem hiding this comment.
But that's the stack trace for Contao 5. This PR is against 4.13 and the error would not occur in that line - it would occur later when the class is tried to be instantiated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Sentry is overflowing because of this error 馃槃