Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant strlen() check #7197

Merged
merged 1 commit into from May 23, 2024
Merged

Remove a redundant strlen() check #7197

merged 1 commit into from May 23, 2024

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented May 7, 2024

This is a follow-up on #7133, where @aschempp has already removed the strlen($v) check from the deleteChildren() method. $v can never be empty, otherwise the loadDataContainer() call would already have triggered a The table name must not be empty exception.

@leofeyer leofeyer added the bug label May 7, 2024
@leofeyer leofeyer added this to the 5.3 milestone May 7, 2024
@leofeyer leofeyer self-assigned this May 7, 2024
@leofeyer leofeyer requested a review from a team May 7, 2024 07:42
@leofeyer leofeyer merged commit 966532a into contao:5.3 May 23, 2024
19 checks passed
@leofeyer leofeyer deleted the fix/strlen branch May 23, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants