Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/armano cli #1998

Merged
merged 2 commits into from Jul 13, 2020
Merged

Refactor/armano cli #1998

merged 2 commits into from Jul 13, 2020

Conversation

byCedric
Copy link
Member

Description

Original PR created at #978
Part of #659

At first i wanted to just migrate it without refactoring, but as meow@v5.0.0 has horrible type and v6 (current) is just a wrapper for yargs (with horrible types) than we can use yargs directly to reduce complexity.

while reviewing i do recommend to disable whitespaces as diff is getting way more readable
https://github.com/conventional-changelog/commitlint/pull/978/files?utf8=✓&diff=split&w=1

Motivation and Context

Ported cli to typescript as part of #659

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat escapedcat merged commit dabdfc9 into master Jul 13, 2020
@escapedcat escapedcat deleted the refactor/armano-cli branch July 13, 2020 03:16
@jimmyandrade
Copy link

@armano2 @byCedric

Hello,

Is version 9.1.1 still depending on meow? We're facing some security issues (natura-cosmeticos/natds-js#752), and we think that they're related to outdated version of yargs-parser / meow from @commitlint/cli.

Thank you

@escapedcat
Copy link
Member

@jimmyandrade

Please give @next a try: #1691 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants