Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): add trailer-exists rule #2578

Merged
merged 2 commits into from May 13, 2021
Merged

feat(rules): add trailer-exists rule #2578

merged 2 commits into from May 13, 2021

Commits on May 12, 2021

  1. feat(rules): add trailer-exists rule

    This new rule behaves similarly to the existing `signed-off-by` rule,
    but introduces what would otherwise be breaking changes to the parser in
    order to resolve some issues.
    
    Rather than attempting to parse the trailers manually, this rule will
    use Git's `interpret-trailers` subcommand to parse trailers according to
    Git's rules. This allows us to properly detect all valid trailers, and
    does not require that the trailer to search for be the last line of the
    commit message (as is required by the `signed-off-by` rule).
    
    One downside to this approach is that Git will not detect trailers if
    they are grouped alongside other trailers with whitespace in the token
    (e.g. `BREAKING CHANGE`). Projects that wish to use this rule may use
    `BREAKING-CHANGE`, which is synonymous with `BREAKING CHANGE` but is
    considered a valid trailer.
    CJKay committed May 12, 2021
    Configuration menu
    Copy the full SHA
    8f86771 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Configuration menu
    Copy the full SHA
    2e0d2be View commit details
    Browse the repository at this point in the history