fix: avoid slicing header if not long enough #3862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent PR[1] didn't take in account very small subjects in subject-full-stop rule. [1] conventional-changelog#3839
knocte
changed the title
|
Should this be tested? |
|
Interestingly enough, I added a test for a short subject (2 characters) and it didn't fail! So I guess "12".slice(-3) might return empty string instead of throwing an exception? |
|
Also needs a rebase :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PR[1] didn't take in account very small subjects in subject-full-stop rule.
[1] #3839