refactor: port read to typescript #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenn-chen
commented
Oct 4, 2019
| @@ -12,5 +12,6 @@ | |||
| { "path": "@commitlint/resolve-extends" }, | |||
| { "path": "@commitlint/to-lines" }, | |||
| { "path": "@commitlint/top-level" }, | |||
| { "path": "@commitlint/read" } | |||
There was a problem hiding this comment.
Because read depends on top-level, I put the path of read under that of top-level here. Otherwise, the build would fail. I cannot find a reference saying that the order matters, it would be great if anyone can tell me something more about this.
There was a problem hiding this comment.
Yeah, this is the order here is equal to the order of compilation. If something depends on another thing, it needs to be listed after that package 😄 So you are correct!
|
Closing in favor of #922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #659
Motivation and Context
Ported read to typescript as part of #659
How Has This Been Tested?Types of changes
Checklist: