Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rules): migrate rules tests from ava to jest #900

Merged
merged 1 commit into from Jan 26, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 19, 2020

Description

From what i understand code is being migrated to jest and typescript, this is middle step that should reduce amount of changes required to be reviewed while doing so.

I'm planning to upgrade tests from each package separately to reduce noise and made it easier to review.

How Has This Been Tested?

Unrelated

Types of changes

  • Tests refactor
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@byCedric
Copy link
Member

byCedric commented Jan 26, 2020

You are my hero ❤️ Yes, we started a TS refactor some time ago here. But due to our limited time it stalled for a bit. Now that I have some time available again, I want to push for the full refactor and complete this step. Maybe we should make a roadmap with some stuff we want to fix, here is a small summary:

  1. Complete full typescript refactor
  2. Update conventional config to latest standard (breaking change)
  3. Deprecate old packages like prompt and prompt-cli, and replace them with proper commitizen adapters
  4. Check if we need to "realign" internal APIs to cover all new features that were added in v8
  5. Improve support for other CI vendors other than Travis (e.g. Bitbucket Pipelines and GitHbu Actions)
  6. Write a dev.to post about Commitlint 9

@byCedric
Copy link
Member

Looks great, I'll merge it right away! ❤️

@byCedric byCedric merged commit b111e8f into conventional-changelog:master Jan 26, 2020
@armano2 armano2 deleted the rules-tests branch January 26, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants