test(read): migrate read tests from ava to jest #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
changed the title
|
I see you are encountering the same issue related to jest getting out of memory. Just patched circle ci to prevent this from happening. If you rebase or merge with master, this should be fixed! |
|
i will do this in a moment i'm finishing converting @packages/test to typescript |
|
done |
|
Looks good to me! Thanks again ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate test read tests from ava to jest, this is continuation of changes done in #886
this package is not yet listed as refactored in #659
How Has This Been Tested?
Unrelated
Types of changes
Checklist: