feat(eslint): improve regex headerPattern (#268)

BREAKING CHANGE: Trailing whitespaces at the beginning of commit messages will not be saved anymore
conventional-changelog · Jan 15, 2018 · ccc1365 · ccc1365
1 parent 3d345e3
commit ccc1365
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/conventional-changelog-eslint/parser-opts.js b/packages/conventional-changelog-eslint/parser-opts.js
@@ -1,7 +1,7 @@
 'use strict';
 
 module.exports = {
-  headerPattern: /^(\w*)\: (.*?)(?:\((.*)\))?$/,
+  headerPattern: /^(\w*):\s*(.*)$/,
   headerCorrespondence: [
     `tag`,
     `message`

diff --git a/packages/conventional-changelog-eslint/test/test.js b/packages/conventional-changelog-eslint/test/test.js
@@ -24,6 +24,8 @@ describe('eslint preset', function() {
     writeFileSync('test4', '');
     shell.exec('git add --all && git commit -m"Docs: Fix unmatched paren in rule description"');
     writeFileSync('test5', '');
+    shell.exec('git add --all && git commit -m"Fix:        Commit with trailing spaces in the beginning"');
+    writeFileSync('test6', '');
     shell.exec('git add --all && git commit -m"Merge pull request #3033 from gcochard/patch-3 "');
   });
 
@@ -40,6 +42,7 @@ describe('eslint preset', function() {
         expect(chunk).to.include('the `no-class-assign` rule');
         expect(chunk).to.include('### Fix');
         expect(chunk).to.include('indent rule should recognize single line statements with ASI');
+        expect(chunk).to.include('* Commit with trailing spaces in the beginning');
         expect(chunk).to.include('### Docs');
 
         expect(chunk).to.not.include('3033');