feat: regex headerPattern for eslint #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? |
|
I added a test case with the beginning trailing whitespaces. Did you mean this test case? |
stevemao
reviewed
Jan 10, 2018
|
👍 I'm fine with this change. I will note that I couldn't actually find any ESLint documentation on whether commit messages are allowed to contain spaces after the commit type and colon. Their documention does say one way or the other. @stevemao should this be a breaking change since the whitespace behavior has changed? |
|
I would see this as breaking change, since this update won't apply to the previous style. Also a fix wouldn't fit, 'cause the lib was never thought to be that way. |
|
@JPeer264 ok. Thanks! Could you squash and change the commit message to follow our standard? Make sure you have a |
|
like this? |
BREAKING CHANGE: Trailing whitespaces at the beginning of commit messages will not be saved anymore
JPeer264
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex got a lot of overhead. The new one is easier to read and faster to parse.
But here I changed the regex a bit. First it also matched whitespaces in the beginning of the message, now it doesnt. If the same behavior is wished, I can change the regex to:
/^(\w*): (.*)$/Which does the same as the original one, but with less overhead