Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revertPattern in angular preset should also match regular revert… #525

Closed
wants to merge 1 commit into from
Closed

fix: revertPattern in angular preset should also match regular revert… #525

wants to merge 1 commit into from

Conversation

YuraBeznos
Copy link

… format

Part of /issues/348

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.614% when pulling d43145e on YuraBeznos:348-Should-revertPattern-in-angular-preset-also-match-regular-revert-format into faa2819 on conventional-changelog:master.

@tommywo
Copy link
Member

tommywo commented Sep 26, 2019

Hi @YuraBeznos. Thank you for contributing. 🎉
Can you add a unit test for that?

@stevemao
Copy link
Member

Should conventional-changelog-conventionalcommits use the default revert message and leave the angular preset as is?

@tommywo
Copy link
Member

tommywo commented Sep 27, 2019

@stevemao https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#revert now doesn't say the message format is autogenerated, but it uses word SHOULD not MUST, so I personally think default message format should be also parsed in angular preset.

@tommywo
Copy link
Member

tommywo commented Oct 9, 2019

@bcoe, @jbottigliero, @byCedric what's your opinion on this? this might affect how commitlint is working after conventional-changelog/commitlint#821 is merged

@bcoe
Copy link
Member

bcoe commented Oct 9, 2019

should we just make the regex case-insensitive? thoughts @tommywo?

@byCedric
Copy link
Member

byCedric commented Oct 9, 2019

@tommywo I don't think this is an issue in Commitlint, it's backwards compatible 😄 (at least, I think it is?) We also keep track of some "ignored commits", like reverts (which is case-insensitive already)

@tommywo
Copy link
Member

tommywo commented Nov 6, 2019

closing in favor of #545

@tommywo tommywo closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants