Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass config to parserOpts and writerOpts #618

Merged
merged 3 commits into from Jun 19, 2020

Conversation

bertho-zero
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.714% when pulling 3bf3486 on bertho-zero:patch-2 into 7a21713 on conventional-changelog:master.

@bcoe
Copy link
Member

bcoe commented May 8, 2020

@bertho-zero what's broken without this, we only get the default configuration I imagine?

Could I bother you to add a test?

@MunifTanjim
Copy link

what's broken without this, we only get the default configuration I imagine?

Yes, without this, it's not possible to use custom configuration. I'm using this change in my project (https://github.com/Synor/synor/blob/71ddc337/patches/conventional-changelog-conventionalcommits%2B4.2.3.dev.patch) and can confirm that it works perfectly.

@acostalima
Copy link

acostalima commented Jun 18, 2020

Hi @bcoe,
When would it be possible to get this merged? We're having issues with lerna when using conventionalcommits preset.

CC @satazor

@bcoe bcoe changed the title fix conventional-changelog.js fix: pass config to parserOpts and writerOpts Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants