Skip to content

Commit

Permalink
fix: stop suggesting npm publish if package.json was not updated
Browse files Browse the repository at this point in the history
  • Loading branch information
MiniGod committed May 5, 2019
1 parent 8cb211f commit 34aadcc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/lifecycles/tag.js
@@ -1,3 +1,4 @@
const bump = require('../lifecycles/bump')
const chalk = require('chalk')
const checkpoint = require('../checkpoint')
const figures = require('figures')
Expand Down Expand Up @@ -28,7 +29,7 @@ function execTag (newVersion, pkgPrivate, args) {
.then(() => runExec('', 'git rev-parse --abbrev-ref HEAD'))
.then((currentBranch) => {
let message = 'git push --follow-tags origin ' + currentBranch.trim()
if (pkgPrivate !== true) {
if (pkgPrivate !== true && bump.getUpdatedConfigs()['package.json']) {
message += ' && npm publish'
if (args.prerelease !== undefined) {
if (args.prerelease === '') {
Expand Down
7 changes: 7 additions & 0 deletions test.js
Expand Up @@ -1030,6 +1030,13 @@ describe('standard-version', function () {
output.stdout.should.include('v5.1.0')
})
})

it('does not display `npm publish` if there is no package.json', function () {
shell.rm('package.json')
const result = execCli()
result.code.should.equal(0)
result.stdout.should.not.match(/npm publish/)
})
})

describe('configuration', () => {
Expand Down

0 comments on commit 34aadcc

Please sign in to comment.