Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Change Log" vs "Changelog"? #299

Closed
ybiquitous opened this issue Jan 31, 2019 · 10 comments
Closed

"Change Log" vs "Changelog"? #299

ybiquitous opened this issue Jan 31, 2019 · 10 comments

Comments

@ybiquitous
Copy link

ybiquitous commented Jan 31, 2019

Hi, I have a question. A CHANGELOG.md file generated by standard-version has a "Change Log" as the first-level heading now. See ⬇️

https://github.com/conventional-changelog/standard-version/blob/25300ff44d398cb48889111fb2b55353265a77db/CHANGELOG.md

Which are the words "Change Log" and "Changelog" correct?

For example, Wikipedia says "Changelog", and I see "Changelog" more than "Change Log" (or "Change log") on the internet.

I'm not an English native, so I'm happy if anyone would help this question!

@stevemao
Copy link
Member

Good question! I usually see "Changelog" instead of "Change Log". But I'll let native speakers to make a call :)

@patrickblackjr
Copy link

Changelog is correct I'm fairly certain. on the olivierlacan/keep-a-changelog#92

See /olivierlacan/keep-a-changelog/

@ybiquitous
Copy link
Author

Thanks. I would like to change from "Change Log" to "Changelog", but this change may cause a breaking change.

So, I think the following steps to introduce the change:

  1. Add new option to change the 1st level heading text in CHANGELOG.md like this: ⬇️
-var header = '# Change Log\n\nAll notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n'
+var firstLevelHeading = options.firstLevelHeading || 'Change Log'
+var header = '# ' + firstLevelHeading + '\n\nAll notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n'

var header = '# Change Log\n\nAll notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n'

  1. On the next major update, the default heading Change Log will be changed to Changelog.

What do you think about this idea?

@stevemao
Copy link
Member

If this causes breaking change, I'd say changing it is not necessary since it's a very minor thing

@cristovaov
Copy link

IMHO, this is more of an easy spelling mistake to fix than a breaking change. I welcome having it corrected when I cut a new release of a project. I've submitted a pull request for it.

@cristovaov
Copy link

Spelling has been fixed by @bcoe in #335 - discussion can be closed, i'd say! :)

@bcoe
Copy link
Member

bcoe commented May 5, 2019

👋 closing, I'll try to have a release out today, as soon as I update all the dependencies with renovate.

@bcoe bcoe closed this as completed May 5, 2019
@ybiquitous
Copy link
Author

Good news! 👏 Thanks a lot! 😄

@bcoe
Copy link
Member

bcoe commented May 6, 2019

@ybiquitous should be fixed in standard-version@6.x.x try it out.

@ybiquitous
Copy link
Author

@bcoe Thanks. When I tried v6, it was so good! 😊 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants