New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(open-source): EX-4666 GitHub specific documentation #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 344e1d3.
herrardo
suggested changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your work Lydia!!
I have left some comments
herrardo
previously approved these changes
Sep 8, 2021
CachedaCodes
suggested changes
Sep 13, 2021
CachedaCodes
suggested changes
Sep 13, 2021
CachedaCodes
previously approved these changes
Sep 14, 2021
herrardo
previously approved these changes
Sep 14, 2021
@lydiafp, I think you could delete the .md version of the templates to start using the .yaml in this PR, could you do that and we approve again? |
herrardo
previously approved these changes
Sep 14, 2021
herrardo
previously approved these changes
Sep 14, 2021
CachedaCodes
previously approved these changes
Sep 14, 2021
CachedaCodes
dismissed stale reviews from herrardo and themself
via
September 14, 2021 13:45
d1090af
CachedaCodes
approved these changes
Sep 14, 2021
herrardo
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Review all GitHub specific documentation in the open source project.
Motivation and Context
As part of the open source initiative, all GitHub specific documentation such as contributing guidelines, naming conventions and issue templates have been reviewed for clarity and consistency.
Bug & feature templates have been converted to YAML format to create a user friendly form. If the new format is accepted, existing template MD files must be deleted in order for GitHub to use the new format as a template. Any MD files in the ISSUE TEMPLATE folder takes precedence.
Type of change
What is the destination branch of this PR?
Main
How Has This Been Tested?
Checklist: