feat(Updaters, bumpFiles, packageFiles): Adds regex built-in updater.
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sébastien Règne <regseb@users.noreply.github.com>
- Ensure `packageFile` parsing supports custo updaters. - Abstracts the updater resolution code for bumpFiles and packageFiles
- Adds a built-in updater for `regex` - Allows passing of `options` to updaters (`readVersion` and `writeVersion` methods)
|
The test failure here is expected based on Travis configured to run in Node@8... |
…of 'replace' RegExps
jbottigliero
force-pushed
the
feat-bump-files
branch
from
57ce557
to
3be2404
Compare
|
Any update of this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regexoptionsto updaters (readVersionandwriteVersionmethods)This updater was added based on feedback provided in #372
A few things to note... at the moment this code is only compatible with
node >= 10based on it's usage of named capture groups and positive lookahead regular expressions.While it may be possible to implement this in some other way... In my opinion, these two features make for the most concise examples and reduced the required complexity of the updater code itself – with positive lookahead we can just call
contents.replace(theProvidedRegExp, newVersion).