Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combining both release-as and prerelease now doesn't break package version #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Combining both release-as and prerelease now doesn't break package version #767

wants to merge 1 commit into from
+40 −2

Commits on Jun 1, 2021

  1. fix: Combining both release-as and prerelease now doesn't break package 

    Previously, as shown in conventional-changelog#542, using both options at the same time resulted in the bump file's version being set to null.

This was validated in the first of the new unit tests. The other unit tests simply check that the rest of the behavior is correct in this case.

With this combination the user can override the version, the purpose of `release-as`, while still starting or continuing a pre-release, the purpose of of the `prerelease`.

Fixes conventional-changelog#542
    @kf6kjg
    kf6kjg committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    dc34a9c View commit details
    Browse the repository at this point in the history