Add generated files to .gitignore when selecting Gulp
#3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when js_task_runner == ' Gulp'. These files are generated automatically in this configuration and as such, mess up git commit periodically.
|
The build seems broken due to an unrelated issue: PyCQA/isort#1874 |
More runtime generated files should be ignored to version control. Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
|
Thanks! |
browniebroke
changed the title
browniebroke
changed the title
.gitignore when selecting Gulp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add project.css and project.min.css to .gitignore when js_task_runner == ' Gulp'. These files are generated automatically in this configuration and, as such, mess up git commit periodically.
Description
cookiecutter-django's default behavior when selecting Gulp as JS Task Runner will result in project.css and project.min.css to be regenerated automatically and periodically.
These auto-generated files should not be part of the repo, as they will mess up version control development activities.
Checklist:
Rationale
According to the docs, selecting Gulp as the JS Task Runner will cause the installation to recompile the SASS project.scss file into project.css (and presumably also project.min.css).
The project.css and project.min.css will show up as changed periodically and mess up development by forcing the user to discard in development or unnecessarily committed to the project repo.
Fix #2857