Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Spotify track/episode support #1603

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Add Spotify track/episode support #1603

wants to merge 2 commits into from

Commits on Mar 28, 2023

  1. feat: Add Spotify track/episode support 

    Using the [Spotify Iframe API](https://developer.spotify.com/documentation/embeds/references/iframe-api), we can embed and control spotify tracks and episodes.

To use this feature, pass a link of format "spotify:track:id" or "spotify:episode:id" to the player.

I also fixed a small issue related to the loop mechanism being broken when using lazy players.

Small note though. To view items, the viewer MUST be logged in with their spotify account (premium not required, unlike the Spotify playback SDK) otherwise they get a 30-sec preview. Functionality is mostly maintained, the clip is simply cut short

Should partially address cookpete#161
    @desmaraisp
    desmaraisp committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    3d1435d View commit details
    Browse the repository at this point in the history

  2. fix: Undefined this.props.onReady 

    onReady wasn't getting triggered by the listener due to scope issues. Moving the onReady call to a different scope should fix the issue
    @desmaraisp
    desmaraisp committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    49be758 View commit details
    Browse the repository at this point in the history