Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psalm/plugin-symfony #14

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Update psalm/plugin-symfony #14

merged 2 commits into from
Feb 3, 2023

Conversation

MatTheCat
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT

Prevent the build from failing thanks to psalm/psalm-plugin-symfony#296

@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4083155768

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2991594815: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

composer.json Outdated
@@ -42,7 +42,7 @@
"phpstan/phpstan-phpunit": "^1.0",
"phpunit/phpunit": "^9.5",
"psalm/plugin-phpunit": "^0.17",
"psalm/plugin-symfony": "^3.1",
"psalm/plugin-symfony": "^4.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the version 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this PR is to fix the CI and this is the smallest upgrade which does it.

Bumping psalm/plugin-symfony would require to bump vimeo/psalm as well and would potentially lead to other things to do so I think it would be better in another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you will do it then! 😉

composer.json Outdated
@@ -42,7 +42,7 @@
"phpstan/phpstan-phpunit": "^1.0",
"phpunit/phpunit": "^9.5",
"psalm/plugin-phpunit": "^0.17",
"psalm/plugin-symfony": "^3.1",
"psalm/plugin-symfony": "^4.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"psalm/plugin-symfony": "^4.0.1",
"psalm/plugin-symfony": "^4.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is not present on psalm/plugin-symfony v4.0.0 that’s why I required ^4.0.1.

@alanpoulain alanpoulain merged commit ac3d9f8 into coopTilleuls:main Feb 3, 2023
@MatTheCat MatTheCat deleted the update-psalm-plugin-symfony branch February 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants