-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update psalm/plugin-symfony #14
Update psalm/plugin-symfony #14
Conversation
Pull Request Test Coverage Report for Build 4083155768Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
composer.json
Outdated
@@ -42,7 +42,7 @@ | |||
"phpstan/phpstan-phpunit": "^1.0", | |||
"phpunit/phpunit": "^9.5", | |||
"psalm/plugin-phpunit": "^0.17", | |||
"psalm/plugin-symfony": "^3.1", | |||
"psalm/plugin-symfony": "^4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using the version 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this PR is to fix the CI and this is the smallest upgrade which does it.
Bumping psalm/plugin-symfony would require to bump vimeo/psalm as well and would potentially lead to other things to do so I think it would be better in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you will do it then! 😉
composer.json
Outdated
@@ -42,7 +42,7 @@ | |||
"phpstan/phpstan-phpunit": "^1.0", | |||
"phpunit/phpunit": "^9.5", | |||
"psalm/plugin-phpunit": "^0.17", | |||
"psalm/plugin-symfony": "^3.1", | |||
"psalm/plugin-symfony": "^4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"psalm/plugin-symfony": "^4.0.1", | |
"psalm/plugin-symfony": "^4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is not present on psalm/plugin-symfony v4.0.0 that’s why I required ^4.0.1
.
Prevent the build from failing thanks to psalm/psalm-plugin-symfony#296