Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[default.nix] Put buildDoc back to true and update nixpkgs to get Sphinx 4.5. #16283

Merged
merged 2 commits into from Jul 9, 2022

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Jul 5, 2022

#15560 has temporarily disabled the documentation build in the Nix CI job (see #16198) by commenting out the appropriate lines and turning buildDoc to false. The latter is redundant and is making it more difficult to get the documentation dependencies in a nix-shell environment, so we turn it back to true.

The update of nixpkgs allow getting Sphinx 4.5 for which support was recently merged (#16193).

Doc build is already commented out. Having buildDoc to true is useful for people using nix-shell to build Coq.
@Zimmi48 Zimmi48 added the kind: infrastructure CI, build tools, development tools. label Jul 5, 2022
@Zimmi48 Zimmi48 added this to the 8.17+rc1 milestone Jul 5, 2022
@Zimmi48 Zimmi48 requested a review from a team as a code owner July 5, 2022 10:15
@Alizter Alizter self-assigned this Jul 9, 2022
@Alizter
Copy link
Contributor

Alizter commented Jul 9, 2022

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 7a86c76 into coq:master Jul 9, 2022
@Zimmi48 Zimmi48 deleted the fix-default-nix branch July 9, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants