Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobuild .merlin files in CI scripts for some plugins #18941

Merged
merged 1 commit into from May 15, 2024

Conversation

SkySkimmer
Copy link
Contributor

No description provided.

@SkySkimmer SkySkimmer added kind: infrastructure CI, build tools, development tools. request: full CI Use this label when you want your next push to trigger a full CI. labels Apr 17, 2024
@SkySkimmer SkySkimmer requested a review from a team as a code owner April 17, 2024 12:27
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 17, 2024
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 18, 2024
@SkySkimmer
Copy link
Contributor Author

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 18, 2024
@ppedrot
Copy link
Member

ppedrot commented Apr 18, 2024

Two questions:

  • Why do we want to do this in the CI?
  • Why isn't the standard makefile generating this target by default?

@ejgallego
Copy link
Member

ejgallego commented Apr 18, 2024

I guess @SkySkimmer wants to this so he gets working merlin support for overlays.

That's still a very much suboptimal developer experience IMO, as compared to the method I was using some time ago (dune build @check with overlays enabled)

@SkySkimmer
Copy link
Contributor Author

I use dune build check for some projects where the CI uses dune (eg serapi, tactician) but it's also nice to be able to just make ci-foo and jump to the error line

@ppedrot ppedrot added this to the 8.20+rc1 milestone May 15, 2024
@ppedrot ppedrot self-assigned this May 15, 2024
@ppedrot
Copy link
Member

ppedrot commented May 15, 2024

Let's merge, this is indeed trivial. @coqbot merge now

@coqbot-app coqbot-app bot merged commit db194bb into coq:master May 15, 2024
6 checks passed
@SkySkimmer SkySkimmer deleted the ci-merlin branch May 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants