Getting logits to the client code #2340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reuben can we get approval to run the workflows? |
|
@reuben the commits did pass the Lint tests but I am not sure what went wrong in the tests that failed. Do you happen to know what went wrong? |
|
Seems to be a couple of independent issues with the various platforms. |
|
@reuben thoughts on how to resolve them? Some of them don't seem to be issues with this PR, but rather general issues, no? |
|
As skeilnet suggested, I've created a new branch (logits) and I have raised another pull request #2352. I will be closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2075, and #2339, to return the model outputs to the user.