[CORL-2385] Downgrade to node v12 #3761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for gallant-galileo-14878c canceled. 🔨 Explore the source changes: 9f41008 🔍 Inspect the deploy log: https://app.netlify.com/sites/gallant-galileo-14878c/deploys/61798e216c5af20008d4e677 |
nick-funk
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following issue describes memory leak issues with
vm.Scriptthat we are using to scan comment content for suspect and banned words.Contrary to the issue's title, it also does affect Node v12 but in a different way.
Before we introduce more "weirdness", we should deal with current mem leaks, or find an alternative to
vm.Script.vmScriptmemory leak in Node.js 14 / 16 nodejs/node#40014Additionally memory dumps are crashing in v14 builds: