Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/loadbalance: add limit_answers option #6511

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danhanks
Copy link

1. Why is this pull request needed and what does it do?

This PR proposes an addition to the loadbalance plugin enabling it to limit the number of RRs in the Answers section of a DNS response after it has been shuffled / weighted by the plugin.

2. Which issues (if any) are related?

A similar capability is discussed in #6337 with the proposed oneaddr plugin. I commented there about the possibility of expanding that capability from 1 to N. This is the first step in that direction.

3. Which documentation changes (if any) need to be made?

Changes to the README.md (as outlined in this first commit) for the loadbalance plugin, also probably plugin docs on coredns.io.

4. Does this introduce a backward incompatible change or deprecation?

No.

Assuming the syntax / format of this addition are approved, I plan to push additional commits to this PR to implement this proposed change.

Starting with changes to the README.md by way of proposal.

Signed-off-by: Dan Hanks <danhanks@gmail.com>
@danhanks danhanks requested a review from miekg as a code owner February 21, 2024 19:10
@chrisohaver
Copy link
Member

syntax looks good

@chrisohaver chrisohaver requested review from chrisohaver and removed request for miekg March 7, 2024 19:27
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.45%. Comparing base (93c57b6) to head (ab45cf3).
Report is 1135 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6511      +/-   ##
==========================================
+ Coverage   55.70%   58.45%   +2.74%     
==========================================
  Files         224      252      +28     
  Lines       10016    16568    +6552     
==========================================
+ Hits         5579     9684    +4105     
- Misses       3978     6292    +2314     
- Partials      459      592     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisohaver chrisohaver marked this pull request as draft March 7, 2024 19:43
@chrisohaver chrisohaver changed the title limit_answers addition to loadbalance plugin plugin/loadbalance: add limit_answers option Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants