Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable clock skew #326

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Add configurable clock skew #326

wants to merge 1 commit into from

Conversation

cgostuff
Copy link
Contributor

@cgostuff cgostuff commented Dec 14, 2021

This implements clock skew similar to AzureAD. The existing solution with 5 min nbf leeway and a configurable time function does not let you get a true 5 min clock skew, because the time.now() function used to check expiry is reused to check the nbf-constraint.

This is configurable in .NET TokenValidationParameters.ClockSkew Property, and is used like this in IdentityServer4 PrivateKeyJwtSecretValidator.cs#L106.

@jordaniversen
Copy link

Any word on this? I was also looking for such a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants