New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/resource: Support gcs urls in Ignition config #1000
Conversation
Can one of the admins verify this patch? |
2578e88
to
7623bac
Compare
Have you tested authenticated fetch of a non-public object? |
b9c753b
to
d166166
Compare
Yes, just confirmed it's working fine for the older code. Let me test it again after incorporating your suggestions. |
b348612
to
cbb584b
Compare
This looks good. No deviations from the previous finding. |
82cb215
to
d25d347
Compare
Note that the OpenCensus version we vendored in this patch is causing issues in early boot systems with low entropy: census-instrumentation/opencensus-go#1228. If we get that (or something functionally equivalent) merged there, then let's update the vendoring here to get that in. |
Great work tracking that down @jlebon |
This is done in #1107. |
Fixes #707
I could see the following information on the serial console log after performing some testing around these changes.