Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/resource: Support gcs urls in Ignition config #1000

Merged
merged 4 commits into from Jun 19, 2020

Conversation

sohankunkerkar
Copy link
Member

Fixes #707
I could see the following information on the serial console log after performing some testing around these changes.

[    7.930150] ignition[678]: DEBUG    : parsing config with SHA512: 05f47789410ba7da511ce86c0dc350ba4a7f736092530044097f8611656ffc297b351eed2b5141e7736ef2bd8ba992a95c6f8c0a55a906142cf464265c12beb1
[    7.932253] ignition[678]: DEBUG    : Warning: falling back to unauthenticated GCS access: google: could not find default credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
[    7.934666] ignition[678]: DEBUG    : fetched referenced config at gs://coreos-ignition-test/test.ign with SHA512: cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e

@coreosbot
Copy link
Contributor

Can one of the admins verify this patch?

@bgilbert
Copy link
Contributor

Have you tested authenticated fetch of a non-public object?

internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
config/v3_0/types/url.go Outdated Show resolved Hide resolved
@sohankunkerkar
Copy link
Member Author

Have you tested authenticated fetch of a non-public object?

Yes, just confirmed it's working fine for the older code. Let me test it again after incorporating your suggestions.

@sohankunkerkar
Copy link
Member Author

Have you tested authenticated fetch of a non-public object?

Yes, just confirmed it's working fine for the older code. Let me test it again after incorporating your suggestions.

This looks good. No deviations from the previous finding.

@sohankunkerkar sohankunkerkar changed the title WIP internal/resource: Support gcs urls in Ignition config internal/resource: Support gcs urls in Ignition config Jun 18, 2020
@sohankunkerkar sohankunkerkar marked this pull request as ready for review June 18, 2020 19:41
internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
@sohankunkerkar sohankunkerkar merged commit 6375df8 into coreos:master Jun 19, 2020
@sohankunkerkar sohankunkerkar deleted the add-gcs branch June 19, 2020 02:19
@jlebon
Copy link
Member

jlebon commented Oct 1, 2020

Note that the OpenCensus version we vendored in this patch is causing issues in early boot systems with low entropy: census-instrumentation/opencensus-go#1228.

If we get that (or something functionally equivalent) merged there, then let's update the vendoring here to get that in.

@arithx
Copy link
Contributor

arithx commented Oct 1, 2020

Great work tracking that down @jlebon

@jlebon
Copy link
Member

jlebon commented Oct 7, 2020

If we get that (or something functionally equivalent) merged there, then let's update the vendoring here to get that in.

This is done in #1107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GCS urls for ignition?
5 participants