core: Don't try to update libdnf _TYPE_MEDIA repos #1703
Conversation
Ref: https://discussion.fedoraproject.org/t/rpm-ostree-giving-error/772/2 Currently plugging in a live USB will auto-create a `media` repo and then cause rpm-ostree to error out. I think we should really change libdnf to silently do nothing for this rather than error out, but that blocks on the rebase.
| if (dnf_repo_get_kind (repo) != DNF_REPO_KIND_MEDIA) | ||
| { | ||
| if (!dnf_repo_update (repo, DNF_REPO_UPDATE_FLAG_FORCE, hifstate, error)) | ||
| return FALSE; |
There was a problem hiding this comment.
Were you able to test this out?
ISTM like dnf_repo_update would still be called on that repo when we do dnf_context_setup_sack_with_flags() below, no? The flow there is similar to what we have here:
ret = dnf_repo_check(repo,
permissible_cache_age,
state_local,
&error_local);
if (!ret) {
g_debug("failed to check, attempting update: %s",
error_local->message);
g_clear_error(&error_local);
dnf_state_reset(state_local);
ret = dnf_repo_update(repo,
DNF_REPO_UPDATE_FLAG_FORCE,
state_local,
&error_local);There was a problem hiding this comment.
Ah yeah, should have noted I didn't test it beyond compilation. Looks like you're right.
|
This problem occurs if you have an opensuse tumbleweed net install image on an usb stick. |
|
A google search led me to https://bugzilla.redhat.com/show_bug.cgi?id=1716067 which links to rpm-software-management/libdnf#838 which claims to fix this. |
|
@cgwalters: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Ref: https://discussion.fedoraproject.org/t/rpm-ostree-giving-error/772/2
Currently plugging in a live USB will auto-create a
mediarepoand then cause rpm-ostree to error out.
I think we should really change libdnf to silently do nothing for
this rather than error out, but that blocks on the rebase.