Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkglist: Canonicalize "no packages" to "no database found" #3183

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Member

It can happen that we successfully query zero packages. For example,
when rpm-ostree on RHEL8 (assuming bdb database) is trying to parse an
ostree commit generated from fedora (sqlite rpmdb), librpm will just give us
nothing. Eventually perhaps we may need to fall back to actually running
the target commit as a container just to get this data for cases like that.

Specifically, I hit this doing
rpm-ostree rebase --experimental ostree-unverified-image:registry:quay.io/cgwalters/fcos-derivation-example
on RHCOS8.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cgwalters
Copy link
Member Author

Only compile tested locally so
/test all
Now, clearly a few things needed here:

  • Need a test case
  • The higher level code around print_treepkg_diff_from_sysroot_path() in particular needs to more gracefully say e.g. Unable to compute package diff; no rpmdb found in commit %s or so.

It can happen that we successfully query zero packages.  For example,
when rpm-ostree on RHEL8 (assuming bdb database) is trying to parse an
ostree commit generated from fedora (sqlite rpmdb), librpm will just give us
nothing.  Eventually perhaps we may need to fall back to actually running
the target commit as a container just to get this data for cases like that.

Specifically, I hit this doing
`rpm-ostree rebase --experimental ostree-unverified-image:registry:quay.io/cgwalters/fcos-derivation-example`
on RHCOS8.
@cgwalters
Copy link
Member Author

/test all

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

@cgwalters: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build-clang 9369c6a link true /test build-clang
ci/prow/clang-analyzer 9369c6a link true /test clang-analyzer
ci/prow/images 9369c6a link true /test images
ci/prow/fcos-e2e 9369c6a link true /test fcos-e2e
ci/prow/kola-upgrade 9369c6a link true /test kola-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant